feat: enable compression of docs stored on S3 #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: trustification#925 Signed-off-by: Jim Crossley <[email protected]>
ctron
reviewed
Oct 28, 2024
ctron
reviewed
Oct 28, 2024
ctron
reviewed
Oct 28, 2024
Mostly to account for the ParseError from the strum FromStr impl... and then I got carried away. Signed-off-by: Jim Crossley <[email protected]>
For the purposes of storing opaque docs, the only header we care about is content-encoding. For us, the default content-type of "application/octet-stream" is fine. Signed-off-by: Jim Crossley <[email protected]>
ctron
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #925